Skip to content

feat(layout): add azerty_AFNOR layout (@JacquesHumule)#7376

Merged
Miodec merged 5 commits intomonkeytypegame:masterfrom
JacquesHumule:layout-azerty-afnor
Feb 27, 2026
Merged

feat(layout): add azerty_AFNOR layout (@JacquesHumule)#7376
Miodec merged 5 commits intomonkeytypegame:masterfrom
JacquesHumule:layout-azerty-afnor

Conversation

@JacquesHumule
Copy link
Contributor

@JacquesHumule JacquesHumule commented Jan 16, 2026 •
edited
Loading

Description

Add azerty AFNOR layout.
Standard

Some diacritics are missing because of the lack of a proper non-diacritic symbols that describes it.

Checks

  • Adding/modifying Typescript code?
    • I have used qs, qsa or qsr instead of JQuery selectors.
  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the themes documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

Copilot AI review requested due to automatic review settings January 16, 2026 09:33
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. packages Changes in local packages labels Jan 16, 2026
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Jan 16, 2026
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the AZERTY AFNOR (NF Z71-300) keyboard layout, the French national standard keyboard layout.

Changes:

  • Added the layout definition file azerty_AFNOR.json with ISO format specifications
  • Registered the layout name in the schema enum

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/schemas/src/layouts.ts Adds "azerty_AFNOR" to the LayoutNameSchema enum
frontend/static/layouts/azerty_AFNOR.json Defines the complete AZERTY AFNOR keyboard layout with all key mappings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 16, 2026
@JacquesHumule JacquesHumule marked this pull request as draft January 23, 2026 14:12
@JacquesHumule JacquesHumule marked this pull request as ready for review January 23, 2026 14:12
@github-actions github-actions bot added waiting for review Pull requests that require a review before continuing and removed waiting for review Pull requests that require a review before continuing labels Jan 23, 2026
@JacquesHumule JacquesHumule requested a review from Copilot January 23, 2026 14:15
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 23, 2026
Copilot AI reviewed Jan 23, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/schemas/src/layouts.ts Outdated
"persian_standard_colemak",
"ergo_split46",
"tamil99",
"azerty_AFNOR",
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout name "azerty_AFNOR" is placed at the end of the enum list (line 235), but following the existing convention in the codebase, it should be placed immediately after "azerty" (around line 47). This follows the pattern where "bepo_AFNOR" is placed right after "bepo" on lines 48-49.

Copilot uses AI. Check for mistakes.
frontend/static/layouts/azerty_AFNOR.json
[":", "…", "·"],
[";", "=", "≃", "≠"]
],
"row5": [[" ", " ", " ", " "]]
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The row5 definition includes four identical space characters. While this is technically valid according to the schema, it's unusual compared to other layouts in the codebase which typically use a single space character. Consider simplifying this to [[" "]] unless there's a specific reason for the AFNOR standard to define multiple space variants at different modifier levels.

Suggested change
"row5": [[" ", " ", " ", " "]]
"row5": [[" "]]

Copilot uses AI. Check for mistakes.
@Miodec Miodec merged commit 7c66fd7 into monkeytypegame:master Feb 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff packages Changes in local packages waiting for review Pull requests that require a review before continuing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacquesHumule @Miodec @monkeytypegeorge